Search-In-Worspace: no more different substrings/duplicates in search result #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbicker
commented
Jun 10, 2020
| if (searchId) { | ||
| this.searchService.cancel(searchId); | ||
| } | ||
| this.cancelIndicator = undefined; |
There was a problem hiding this comment.
Problem was, that this handler was sometimes called after a new cancelIndicator was already created and so immediately set it back to undefined, which then caused that earlier tokens never got cancelled.
jbicker
requested review from
svenefftinge,
AlexTugarev and
vince-fugnitto
and removed request for
akosyakov
jbicker
changed the title
akosyakov
added
the
search in workspace
The link does not work. |
Thanks! Obviously I expected too much and tested the comment too less. |
kittaakos
approved these changes
Jun 17, 2020
kittaakos
reviewed
Jun 17, 2020
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Show resolved
Hide resolved
jbicker
force-pushed
the
jbicker/search-in-workspace-search-7282
branch
from
ef36e65
to
ac65a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It solves the bug described here: #7282.
TL;DR: Sometimes one had different substrings in the search results and so one line shown more than once.
Fixes #7282
How to test
Type into the search box a search term and keep typing while the search is performed in the background. E.g. search for “ContainerModule”. Stop typing and wait for the result list.
There shouldn't be any duplicates anymore.
Review checklist
Reminder for reviewers