workspace: do not load an invalid workspace file #7922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
bug
paul-marechal
force-pushed
the
mp/workspace-check
branch
from
370e980
to
77c4725
Compare
lmcbout
approved these changes
May 28, 2020
The workspace service will fail to open a workspace when the specified workspace file is not actually one. This commit prevents Theia from loading invalid workspace files. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com> Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
mp/workspace-check
branch
from
77c4725
to
a4add6a
Compare
|
@marechal-p I've updated the test cases
The CI is now green again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workspace service will fail to open a workspace when the specified
workspace file is not valid.
How to test
Try to open a workspace with a random file, it should prevent you from doing so.
Review checklist
Reminder for reviewers