Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind commands for terminal.sendSequence and terminal.kill #7906

Merged
merged 1 commit into from
May 28, 2020

Conversation

vzhukovs
Copy link
Contributor

What it does

This changes proposal adds binds for workbench.action.terminal.sendSequence [1] and workbench.action.terminal.kill [2] commands.

[1] microsoft/vscode/src/vs/workbench/contrib/terminal/browser/terminalActions.ts#L1062-L1087
[2] microsoft/vscode/src/vs/workbench/contrib/terminal/browser/terminalActions.ts#L98-L119

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

How to test

  • Use Didact extension

  • Create Sample.didact.md file and paste this content

  • From context menu select item Didact: Start Didact Tutorial from File

Снимок экрана 2020-05-27 в 14 09 30

  • Then click on link [1] to call workbench.action.terminal.sendSequence command and click on link [2] to call workbench.action.terminal.kill command

Снимок экрана 2020-05-27 в 14 10 40

Review checklist

Reminder for reviewers

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs added enhancement issues that are enhancements to current functionality - nice to haves Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility labels May 27, 2020
@vzhukovs vzhukovs self-assigned this May 27, 2020
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked according to "How to test" - works as expected

@vzhukovs vzhukovs merged commit 48eeea9 into master May 28, 2020
@vzhukovs vzhukovs deleted the terminal_commands branch May 28, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants