Set the upstream remote branch when pushing #7866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nigel Westbury <nigelipse@miegel.org>
svenefftinge
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fixes #7596
The issue reported against Gitpod has also been reported against Mbed Studio.
This is a very simple fix that always ensures the remote branch is set when pushing. If the user pushes to a different remote then the remote branch will be switched to that remote.
This was a problem with the Git Theia extension only. The vs-code Git builtin asks the user to confirm that the branch should be published.
How to test
Create a new branch and push. Then try pulling from that branch. Check other workflows to ensure that we are not interfering with existing workflows by always setting the remote tracking branch.
Review checklist
Reminder for reviewers