Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VSCode Command workbench.action.revertAndCloseActiveEditor #7702

Merged
merged 1 commit into from
May 1, 2020

Conversation

nmorenor
Copy link
Contributor

Signed-off-by: Ignacio Moreno ignacio@genuitec.com

What it does

Provides ability to execute the vscode command workbench.action.revertAndCloseActiveEditor from extensions.

How to test

This was tested with the Codetogether extension since it does use this command.

  1. Install the extension
  2. Start a session via command palette.
  3. On the remote session on browser take control and start opening different files.
  4. Once the Theia IDE Browser window takes focus you'll see that only the last opened file is open.

@nmorenor
Copy link
Contributor Author

This should resolve the issue #7575

@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Apr 30, 2020
@vince-fugnitto
Copy link
Member

@nmorenor thank you for the contribution, can you please squash your commits before we proceed for another round of review?

- Force close of editor in case document.revert fails

Signed-off-by: Ignacio Moreno <ignacio@genuitec.com>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@akosyakov akosyakov merged commit 0f931f2 into eclipse-theia:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants