feat(plugin): Use product applicationName to return the value to plugins env.appName

[benoitf]

What it does

Use product applicationName to return the value to plugins env.appName
Thus branding is applied everywhere.

How to test

Clone a java project and takes a plug-in using the appName like Red Hat vscode-java
https://github.com/redhat-developer/vscode-java/releases/download/v0.55.1/redhat.java-0.55.1.vsix

Starts the examples/browser and notice the new name

Now, remove theia element of examples/browser/package.json

"theia": {
    "frontend": {
      "config": {
        "applicationName": "Theia Browser Example",
        "preferences": {
          "files.enableTrash": false
        }
      }
    }
  },

and check default Theia value is used (which is also the name seen in about/dialog)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Change-Id: Ifdda9b5cd64ea34de8292bd16703b87d81700c39
Signed-off-by: Florent Benoit fbenoit@redhat.com

[vince-fugnitto]

The changes look good to me and it's much better now that it picks up the appName.
I tested when a name is provided and when it is not (default name):

[benoitf]

thanks @vince-fugnitto

I will merge tomorrow to allow others to add their review.

[akosyakov]

Should we update here:

theia/dev-packages/application-package/src/application-props.ts

Line 81 in 7217b4f

applicationName: 'Theia'

to Eclipse Theia?

[akosyakov]

LGTM

[benoitf]

Should we update here:

theia/dev-packages/application-package/src/application-props.ts

Line 81 in 7217b4f

applicationName: 'Theia'

to Eclipse Theia?

@akosyakov we could yes, maybe in a different PR ?

[akosyakov]

@benoitf sounds good

[benoitf]

merging this one and I've opened #7656 as per comments.