[hosted plugin] fix no indication for selecting an invalid node.js project #7636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When selecting a node.js project that is not a valid plugin(vscode ext or theia plugin) for hosted plugin instance, it failed selecting the project as expected but doesn't notify the user.
In the hosted-plugin-manager-client.js it checks if the plugin is valid. then the isPluginValid function in hosted-instance-manger.js (backend) calling to getScanner which throws an error because there's no valid scanner for this project.
I wrote a code to catch this error in the
isPluginValid
function and returnfalse
to the client accordingly.Before:
After:
How to test
Clone node.js project which is not a vscode extension or theia plugin.
Press f1 -> Hosted Plugin: Select Path -> select the project.
See that there's a notification telling the user that the folder is not a valid plugin.
Review checklist
Reminder for reviewers