Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't paste to active editor when a tab is closed by mouse wheel click #7565

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Apr 14, 2020

What it does

Fixes a bug

How to test

Part A (Bug reproduction, on master branch):

  1. Open two editor tabs
  2. Focus on one tab (cursor should be in editor)
    image
    (In my case my cursor is in the Landing.vue editor, I can edit there and I close launch.json)
  3. Close the other tab with mouse wheel click
  4. See that clipboard content was pasted into active editor
    Part B (Testing the fix):
  5. Try to reproduce bug from part A
  6. See that the tab just closes

Tested in Firefox 76

Review checklist

Reminder for reviewers

Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>
@akosyakov akosyakov added the shell issues related to the core shell label Apr 14, 2020
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Firefox 75, works like a charm!

@akosyakov
Copy link
Member

@marechal-p please merge, code wise it does not seem to have big impact

@paul-marechal paul-marechal merged commit e2dfc1a into eclipse-theia:master Apr 15, 2020
@dsseng dsseng deleted the fix-auxclick branch April 15, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell issues related to the core shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants