Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable git initialize repository when no open workspace #7492

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

umcconnell
Copy link
Contributor

Fixes #7487

Signed-off-by: Ulysse McConnell ulysse.mcconnell+dev@protonmail.com

What it does

Disables and hides the git 'Initialize repository' widget when no workspace is open

How to test

  1. Remove any open workspaces
  2. Switch to the source control panel

Review checklist

Reminder for reviewers

Fixes eclipse-theia#7487

Signed-off-by: Ulysse McConnell <ulysse.mcconnell+dev@protonmail.com>
@akosyakov akosyakov requested a review from kittaakos April 3, 2020 07:57
@akosyakov akosyakov added the git issues related to git label Apr 3, 2020
@akosyakov akosyakov requested a review from westbury April 3, 2020 07:57
@kittaakos
Copy link
Contributor

@umcconnell, you have to sign the ECA. Please make sure you use the same email address as you have used for signing you Git commit. Thank you!

@umcconnell
Copy link
Contributor Author

@kittaakos Ok, I signed it. Thanks 👍
Is there anything I have to change to my commit regarding the signature?

@kittaakos
Copy link
Contributor

anything I have to change

No. I have re-run the ECA validation, it's OK now. Thank you!
I am going to look into your changes and verify it a little bit later, but it looks OK to me. 👍

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified; it works as expected.

Before:
Screen Shot 2020-04-04 at 14 08 57

After:
Screen Shot 2020-04-04 at 14 12 27

Thank you for your contribution, @umcconnell 👍

@kittaakos kittaakos merged commit 2270537 into eclipse-theia:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[git] 'Initialize Repository' available even no open workspace
3 participants