Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to provide a custom node for ReactWidget #7422

Merged
merged 1 commit into from
Mar 26, 2020
Merged

allow to provide a custom node for ReactWidget #7422

merged 1 commit into from
Mar 26, 2020

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Mar 25, 2020 •
edited
Loading

What it does

How to test

Check that application started and react based widgets are not broken

Review checklist

Reminder for reviewers

@akosyakov
fix #7420: allow to provide a custom node for ReactWidget
448120c 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added the core issues related to the core of the application label Mar 25, 2020
vince-fugnitto
vince-fugnitto approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me, I verified that:

  • the CI successfully passed
  • the application successfully starts with no related errors
  • react widgets are working well and there are no visible regressions

@kittaakos kittaakos mentioned this pull request Mar 26, 2020
Closed
@akosyakov akosyakov merged commit 739522d into master Mar 26, 2020
@akosyakov akosyakov deleted the akosyakov/it-should-be-possible-7420 branch March 26, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@jbicker jbicker Awaiting requested review from jbicker

Assignees
No one assigned
Labels
core issues related to the core of the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It should be possible to provide options to ReactWidget.
2 participants
@akosyakov @vince-fugnitto