repo: fix misc typos #7409
Merged
repo: fix misc typos #7409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
quality
marcdumais-work
approved these changes
Mar 24, 2020
packages/plugin-ext/src/main/browser/view/view-context-key-service.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/browser/view/view-context-key-service.ts
Outdated
Show resolved
Hide resolved
vince-fugnitto
force-pushed
the
vf/typo-updates
branch
2 times, most recently
from
7b2c3ad
to
a89f66d
Compare
|
@vince-fugnitto feel free to merge when you're ready |
I thought of giving more time to see if people were against the small breaking changes or not. |
benoitf
approved these changes
Mar 25, 2020
vince-fugnitto
force-pushed
the
vf/typo-updates
branch
3 times, most recently
from
dd316fd
to
b03b3ac
Compare
This commit fixes a number of typos present in different extensions. There are a few notable potential breaking updates: - [debug] renamed `debuggingStaturBar` to `debuggingStatusBar` - [plugin] renamed `CancelationTokenImpl` to `CancellationTokenImpl` - [plugin] renamed `VIEW_ITEM_INLINE_MNUE` to `VIEW_ITEM_INLINE_MENU` - [terminal] renamed `handleWroleWordOptionClicked` to `handleWholeWordOptionClicked` - [workspace] renamed `toDiposeOnUpdateCurrentWidget` to `toDisposeOnUpdateCurrentWidget` Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/typo-updates
branch
from
b03b3ac
to
380c182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This commit fixes a number of typos present in different extensions.
There are a few notable potential breaking updates:
debuggingStaturBartodebuggingStatusBarCancelationTokenImpltoCancellationTokenImplVIEW_ITEM_INLINE_MNUEtoVIEW_ITEM_INLINE_MENUhandleWroleWordOptionClickedtohandleWholeWordOptionClickedtoDiposeOnUpdateCurrentWidgettotoDisposeOnUpdateCurrentWidgetHow to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com