fix plugin header container alignment #6983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doron Nahari <doron.nahari@sap.com>
DoroNahari
force-pushed
the
plugins-header-container
branch
from
2e07980
to
4d2daaa
Compare
|
@benoitf do we merge? |
|
Merging :) Thank you for your contribution @DoroNahari 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Doron Nahari doron.nahari@sap.com
What it does
In the plugins view (view -> plugins), when hovering on one of the plugins you can see that the hover color is not applied on all of the plugin container.
This pr fixes the alignment of each plugin container. the hover color fixed accordingly.
You can see the gap changes between the container and the border in the before and after images.
Before:
After:
How to test
Deploy some plugins to Theia. go to the plugins view (view -> plugins) hover on one of the plugins.
Review checklist
Reminder for reviewers