Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons & file names alignment issue in tree #6973

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Fix icons & file names alignment issue in tree #6973

merged 1 commit into from
Jan 28, 2020

Conversation

kaiyue0329
Copy link
Contributor

Fixes #5580

What it does

  • Adjust the spacing between file icons and file names in navigation tree so that they are aligned vertically and horizontally

How to test

Review checklist

Reminder for reviewers

Fixes #5580

- Adjust the spacing between file icons and file names in navigation tree so that they are aligned vertically and horizontally

Signed-off-by: Kaiyue Pan <kaiyue.pan@ericsson.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaiyue0329 the changes look great, and the it works great too :)
I also verified the icons in the explorer, file quick open, and file dialog.

@akosyakov akosyakov added the tree issues related to the tree (ex: tree widget) label Jan 28, 2020
@akosyakov
Copy link
Member

It does not affect none, minimal and seti themes right? if not please merge

@vince-fugnitto
Copy link
Member

It does not affect none, minimal and seti themes right? if not please merge

I verified and it does not, we only update the file-icon.js icons (default Theia icons) :)

@vince-fugnitto vince-fugnitto merged commit c92eb94 into eclipse-theia:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[navigator] some icons & names are not aligned
3 participants