[core] remove virtual-widget and virtual-renderer #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
vf/GH-2300
branch
from
2ea21cc
to
f4ba030
Compare
|
Please add a word about it in the CHANGELOG. |
Fixes #2300 Both the `virtual-widget` and `virtual-renderer` have been deprecated since #2301. This patch cleans up the codebase to remove the deprecated code as it should no longer be used/supported. - removes the deprecated `virtual-widget`. - removes the deprecated `virtual-renderer`. One should instead opt to use `react-widget` and `react-renderer`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/GH-2300
branch
from
f4ba030
to
6c84259
Compare
Thanks! I updated it to include changelog entries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #2300
Both the
virtual-widgetandvirtual-rendererhave been deprecated since #2301. This patch cleans up the codebase to remove the deprecated code as it should no longer be used/supported.virtual-widget.virtual-renderer.One should instead opt to use
react-widgetandreact-renderer.How to test
Verify that CI successfully passes (build & tests)
Review checklist
Reminder for reviewers