[core] Fixed race condition on contribution initialization

[federicobozzini]

What it does

It fixes #6807 by delayin the registration of menu actions for the folder operations.

How to test

See #6807.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@federicobozzini should we instead opt for a non-blocking asynchronous call?

Example:

@inject(FrontendApplicationStateService)
protected readonly stateService: FrontendApplicationStateService;

async onStart(app: FrontendApplication): Promise<void> { 
    this.stateService.reachedState('ready').then(
         () => this.updateAddRemoveFolderActions(this.menuRegistry);
    );
}

[akosyakov]

please don't use FrontendApplicationStateService, FrontendApplicationContribution provides already with sufficient lifecycle hooks

[federicobozzini]

@vince-fugnitto I've made it non-blocking.

[vince-fugnitto]

@federicobozzini with this change I no longer see the toolbar menu item for Add Folder to Workspace, something which is added by:

this.updateAddRemoveFolderActions(this.menuRegistry);

In order for the item to return, one must right-click the empty area in the navigator for the command to exist. This is a regression from master and we may need to adjust.

[federicobozzini]

@vince-fugnitto Can you please be more specific about where that item should be? On master I see it only in the "Explorer" menu (just above the file navigator) and on the context menu opened on right-click in the navigator. I see the item in the same two places on this branch.

This is on the electron version.

[vince-fugnitto]

I performed additional testing and it does not look to be related to your changes.

---

For future reference, I was referencing the ... (more toolbar item) from the Explorer widget which contains a menu item for Add Folder to Workspace:

[akosyakov]

@vince-fugnitto please merge if it is good