Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Improved Tree View #6342

Merged
merged 1 commit into from
Oct 9, 2019
Merged

[vscode] Improved Tree View #6342

merged 1 commit into from
Oct 9, 2019

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Oct 7, 2019 •
edited
Loading

What it does

Fixes various smaller issues with tree views.

  • handle undefined treeItem.label
  • better styling for item actions
  • support descriptions
  • fix color for inactive selections (layout (grey) not accent (blue))
  • don't execute command on selection change

How to test

Install gitlens extensions and compare the view with VS Code.

Review checklist

Reminder for reviewers

@akosyakov
Copy link
Member

Does it address #6142?

It would be good to test with other tree views, just to check that we handle icons of different formats and sizes good.

Plugin tree bugs were tested before against:

@akosyakov akosyakov added preferences issues related to preferences tree issues related to the tree (ex: tree widget) vscode issues related to VSCode compatibility labels Oct 7, 2019
@svenefftinge
Copy link
Contributor Author

Does it address #6142?

yes, I think so.

@svenefftinge
Copy link
Contributor Author

I will dive in deeper tomorrow

@svenefftinge svenefftinge force-pushed the se/vscode_tree_label branch 3 times, most recently from 2a1f819 to aefbe27 Compare October 8, 2019 07:28
@svenefftinge svenefftinge changed the title [WIP] [vscode] Improved Tree View [vscode] Improved Tree View Oct 8, 2019
@AlexTugarev
Copy link
Contributor

'git it! the preference schema commit is necessary in order to test this PR, otherwise the gitlense extension is not loaded.

@AlexTugarev
Copy link
Contributor

2019-10-08 13 48 08

That's a big improvement!

Though the logs still look slightly reddish for the gitlense extension, the rendering of trees is much nicer!

@svenefftinge
Copy link
Contributor Author

To be clear: This is not fixing all issues the gitlens extension has with Theia. That would be a very big PR. Instead I focussed on the tree view stuff solely. I'm going to look into other issues in separate PRs.

@AlexTugarev
Copy link
Contributor

Got it, thanks! These changes look good to me. Once you've removed the commit from pref schema PR, this is fine.

@svenefftinge
Copy link
Contributor Author

I will fix the other PR so it can be merged and then rebase this on master

@svenefftinge svenefftinge force-pushed the se/vscode_tree_label branch 2 times, most recently from a016b31 to e28b751 Compare October 8, 2019 15:12
@AlexTugarev
Copy link
Contributor

just verified, #6142 is solved in this PR

@svenefftinge
[plugin] tree view improvements
75de763 
- handle undefined treeItem.label
- better styling for item actions
- support descriptions
- fix color for inactive selections (layout (grey) not accent (blue))
- don't execute command on selection change

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
AlexTugarev
AlexTugarev approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves rendering of tree views a lot. Thanks!

@svenefftinge svenefftinge merged commit 65d5925 into master Oct 9, 2019
@svenefftinge svenefftinge deleted the se/vscode_tree_label branch October 9, 2019 07:57
@AlexTugarev AlexTugarev mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy

Assignees
No one assigned
Labels
preferences issues related to preferences tree issues related to the tree (ex: tree widget) vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenefftinge @akosyakov @AlexTugarev