Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] dispose webview by a handle, not a widget id #6326

Merged
merged 1 commit into from
Oct 4, 2019
Merged

[plugin] dispose webview by a handle, not a widget id #6326

merged 1 commit into from
Oct 4, 2019

Conversation

akosyakov
Copy link
Member

What it does

Otherwise the webview is not disposed in the plugin host process.

How to test

  • ext install vscode:extension/humao.rest-client
  • create simple http file
GET https://www.google.com
  • send request
  • close webivew
  • send request again
  • webview should show again
  • there should not be errors about not found webview in the backend logs

Review checklist

Reminder for reviewers

@akosyakov
[plugin] fix #6288: dispose webview by a handle, not a widget id
dec5f2d 
Otherwise the webview is not disposed in the plugin host process.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility webviews issues related to webviews labels Oct 4, 2019
@akosyakov
Copy link
Member Author

@502647092 does it fix #6288 for you?

svenefftinge
svenefftinge approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well again

@akosyakov akosyakov merged commit 5e8c3d8 into master Oct 4, 2019
@akosyakov akosyakov deleted the GH-6288 branch October 4, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@AlexTugarev AlexTugarev Awaiting requested review from AlexTugarev

@azatsarynnyy azatsarynnyy Awaiting requested review from azatsarynnyy

@benoitf benoitf Awaiting requested review from benoitf

@evidolob evidolob Awaiting requested review from evidolob

@olexii4 olexii4 Awaiting requested review from olexii4

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

Assignees
No one assigned
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vscode][webview]plugin can't open webview after close
2 participants
@akosyakov @svenefftinge