Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass plugin information through to languages-main #6214

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

JPinkney
Copy link
Contributor

What it does

This PR passes some plugin info through to languages-main and establishes a map that allows one to get a handle for a specific vscode extension's language server call.

An example of this map is:

{
    "redhat.vscode-yaml": {
        "completion": 0,
        "outline": 1
    },
    "redhat.java": {
        "completion": 2,
        "outline": 3,
        "codeLens": 4
   }
}

Related issue: #6151

How to test

I've created a sample theia extension https://github.com/JPinkney/Theia-Test-Extension that you clone into theia/packages/ and then add "@theia/test-extension": "^.0.10.0" to the package.json. Then add a plugin to the plugins folder such as vscode-java, vscode-xml. Inside of theia open a java and xml file (so the vscode extensions get activated). Then open up the browsers console and after 10 seconds you should see a printout of the map.

Review checklist

Reminder for reviewers

@JPinkney JPinkney changed the title Pass some plugin info through to languages-main Pass plugin information through to languages-main Sep 18, 2019
@JPinkney JPinkney added the plug-in system issues related to the plug-in system label Sep 18, 2019
@JPinkney JPinkney force-pushed the plugin-info branch 2 times, most recently from bd52d26 to 46cf5fb Compare September 19, 2019 13:16
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@JPinkney
Copy link
Contributor Author

@akosyakov I've renamed languages-info to plugin-info as requested. Do you want to take a look again or do you want me to just merge?

@akosyakov
Copy link
Member

@JPinkney merge it :)

@JPinkney JPinkney merged commit f25652a into eclipse-theia:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants