Pass plugin information through to languages-main #6214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR passes some plugin info through to languages-main and establishes a map that allows one to get a handle for a specific vscode extension's language server call.
An example of this map is:
Related issue: #6151
How to test
I've created a sample theia extension https://github.com/JPinkney/Theia-Test-Extension that you clone into theia/packages/ and then add
"@theia/test-extension": "^.0.10.0"
to the package.json. Then add a plugin to the plugins folder such as vscode-java, vscode-xml. Inside of theia open a java and xml file (so the vscode extensions get activated). Then open up the browsers console and after 10 seconds you should see a printout of the map.Review checklist
Reminder for reviewers