-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify plugin unzipping log info to one line #6149
simplify plugin unzipping log info to one line #6149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Tested with a .vsix extension and only a line on the console, not the full JSON data structure
packages/plugin-ext-vscode/src/node/plugin-vscode-file-handler.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/node/handlers/plugin-theia-file-handler.ts
Outdated
Show resolved
Hide resolved
@akosyakov do you know how a plugin can fail resolving or fail to load? Also, I don't know if we agreed on what format and params should be present when logging the unzipping of plugins, but is it sufficient to display the path, and copy path only? |
@vince-fugnitto try to point to something what is no zip file, but has vsix extension Having a source and target paths is enough to me, as it is done in the PR. |
Question, I tried to install in VSCode the following plugin I get the following error: but if I unzip it in Theia, I don't get an indication whether the plugin works or not ? |
You should be able to see all deployed plugins in |
@vince-fugnitto I didn't change the error log in this PR, and it will show the failed log like this: |
@kpge please squash suggestions commit |
Signed-off-by: kpge <gekangping@126.com> Apply suggestions from code review Co-Authored-By: Florent BENOIT <fbenoit@redhat.com>
a33b296
to
ed290a5
Compare
@akosyakov ok, I have rebased it. |
What it does
fix: #6138
How to test
Simplify plugin unzipping log info to one line :
Review checklist
Reminder for reviewers