Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify plugin unzipping log info to one line #6149

Merged

Conversation

kpge
Copy link
Contributor

@kpge kpge commented Sep 10, 2019

What it does

fix: #6138

How to test

Simplify plugin unzipping log info to one line :
image

  • create plugins folder under Theia repo folder
  • Google for an extension (*.vsix file) and download it to the plugins folder
  • start Theia browser example
  • check the log in terminal or console

Review checklist

Reminder for reviewers

@kpge kpge requested a review from a team as a code owner September 10, 2019 08:15
@akosyakov akosyakov added the plug-in system issues related to the plug-in system label Sep 10, 2019
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Tested with a .vsix extension and only a line on the console, not the full JSON data structure

@vince-fugnitto
Copy link
Member

@akosyakov do you know how a plugin can fail resolving or fail to load?
I'd like to test in that case if we get a meaningful message.

Also, I don't know if we agreed on what format and params should be present when logging the unzipping of plugins, but is it sufficient to display the path, and copy path only?

@akosyakov
Copy link
Member

@vince-fugnitto try to point to something what is no zip file, but has vsix extension

Having a source and target paths is enough to me, as it is done in the PR.

@lmcbout
Copy link
Contributor

lmcbout commented Sep 10, 2019

Question, I tried to install in VSCode the following plugin I get the following error:
Unable to install 'jabacchetta.vscode-essentials' extension because it is not compatible with the current version of VS Code (version 1.37.1).

but if I unzip it in Theia, I don't get an indication whether the plugin works or not ?
Should we have an indication if the plugin is usable or not ?

@akosyakov
Copy link
Member

You should be able to see all deployed plugins in Plugins view. If it is not there it is an indicator. For any plugin which is there you will receive an error notification if it cannot be loaded or activated.

@benoitf
Copy link
Contributor

benoitf commented Sep 10, 2019

@lmcbout AFAIK the new default for VS Code version is 1.38
you can override the check with VSCODE_API_VERSION env variable where you run theia.

#6112

@kpge
Copy link
Contributor Author

kpge commented Sep 10, 2019

I'd like to test in that case if we get a meaningful message.

@vince-fugnitto I didn't change the error log in this PR, and it will show the failed log like this:
image

@akosyakov
Copy link
Member

@kpge please squash suggestions commit

Signed-off-by: kpge <gekangping@126.com>

Apply suggestions from code review

Co-Authored-By: Florent BENOIT <fbenoit@redhat.com>
@kpge kpge force-pushed the kpge/quiet_plugin_unzipping_log branch from a33b296 to ed290a5 Compare September 11, 2019 00:59
@kpge
Copy link
Contributor Author

kpge commented Sep 11, 2019

@kpge please squash suggestions commit

@akosyakov ok, I have rebased it.

@akosyakov akosyakov merged commit e2dc267 into eclipse-theia:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quiet plugin unzipping
5 participants