-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin] fix: dispose deploy listener on close #6127
Conversation
@ensorrow please sign your work and accept ECA, otherwise we cannot continue |
Done |
@ensorrow thank you @marcdumais-work i am not sure why eca check is still not happy Maybe an empty line is required before sign-off line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and make sense to me.
the Signed-Off and the commit e-mail should be the same
|
eca is still not happy :( cc @marcdumais-work |
Signed-off-by: ensorrow <1121264060@qq.com>
Too busy to fix eca problem in time, sorry for that @akosyakov |
@ensorrow thank you for dealing with ECA check :) |
What it does
The deploy listener won't dispose when connection got disposed, which will cause memory leak.
How to test
theia/packages/core/src/common/event.ts
Review checklist
Reminder for reviewers