-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[preferences] Reject invalid preference schemas. #6110
Conversation
@akosyakov if you (or anyone else) is interested, I'm happy to change this to throw an error so it can be handled e.g. in the plugin system in order to make it easier to identity the causing part. In this version the rejection message will contain only the pref key e.g. |
packages/core/src/browser/preferences/preference-contribution.ts
Outdated
Show resolved
Hide resolved
@AlexTugarev throwing is a breaking change, so maybe better no |
@AlexTugarev please file an issue about debug adapters, we need to find a solution for it |
Maybe we should get rid of the |
There are more extensions doing it as well as docker images. |
here #6111 |
Fixes #6106 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested that invalid schema does not break the combined preference schema and schema validation errors are still logged. Thanks @AlexTugarev!
What it does
Fixes #6106
How to test
python.pythonPath
) which was effectively a no-op before.Review checklist
Reminder for reviewers