Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revealWidget provides no visual feedback if widget already visible #9541

Open
colin-grant-work opened this issue Jun 1, 2021 · 0 comments
Open
Labels
editor-preview issues that are related to the editor-preview shell issues related to the core shell

Comments

@colin-grant-work
Copy link
Contributor

Bug Description:

If you click on a file node in the navigator, that file is opened in an editor preview and then it is 'revealed' (but not focused) using the shell.revealWidget. If that widget is still visible and you later click on the file node, nothing happens. In VSCode, the title is changed to the active color, though focus is not transferred to the widget.

Steps to Reproduce:

  1. Set editor.enablePreview preference set to true (default).
  2. Single-click on a file node in the navigator.
  3. Observe that the file is opened but not focused and the title has 'inactive' coloring (grey-ish). In VSCode, it would have 'active' coloring (brighter white or black).
  4. Focus another widget but keep that editor visible.
  5. Observe that in Theia, the color of the title doesn't change, but in VSCode it transitions to 'inactive' coloring.
  6. Click the same file node in the navigator. Observe that in Theia, nothing changes, but in VSCode the editor title gets 'active' coloring again.

Additional Information

  • Operating System: RHEL7
  • Theia Version: 1.14.0
@vince-fugnitto vince-fugnitto added editor-preview issues that are related to the editor-preview shell issues related to the core shell labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-preview issues that are related to the editor-preview shell issues related to the core shell
Projects
None yet
Development

No branches or pull requests

2 participants