Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle ondblclick properly #8168

Open
akosyakov opened this issue Jul 14, 2020 · 0 comments
Open

handle ondblclick properly #8168

akosyakov opened this issue Jul 14, 2020 · 0 comments
Labels
bug bugs found in the application scm issues related to the source control manager tree issues related to the tree (ex: tree widget)

Comments

@akosyakov
Copy link
Member

akosyakov commented Jul 14, 2020

Our code is written with the assumption that onclick and ondblclick events are happening exclusively. Which is not true and they fired together: facebook/react#3185

We should reconsider such handlers. We should be very careful with solving it though, since using timeouts make an event look as not triggered by a user and cause failures for calling DOM apis, in the case if a dbl click event never happens.

It is reproducible by trying to open the file with the dbl click. It will be opened, but you will see there is an additional empty title next to the editor caused by a race condition of opening an editor (dbl click) and editor preview (click) at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application scm issues related to the source control manager tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

No branches or pull requests

1 participant