Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theming: add guards to prevent overriding default monaco coloring #7363

Open
vince-fugnitto opened this issue Mar 18, 2020 · 1 comment
Open
Labels
help wanted issues meant to be picked up, require help monaco issues related to monaco quality issues related to code and application quality theming issues related to theming

Comments

@vince-fugnitto
Copy link
Member

Motivation:

#7351 (comment)

Description

There should be guards in place to prevent overriding monaco coloring.
Monaco defines it's own colors which are used across the application, and it is possible to override such colors which may cause theming issues. Guards should be put in place to prevent such overriding such as to discard updates and log them.

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality theming issues related to theming monaco issues related to monaco labels Mar 18, 2020
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Mar 18, 2020
@akosyakov
Copy link
Member

akosyakov commented Mar 18, 2020

Maybe we can even do it generically and ignore overriding colors with error logging. One has to provide a custom theme if they want to have custom theming, not override colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issues meant to be picked up, require help monaco issues related to monaco quality issues related to code and application quality theming issues related to theming
Projects
None yet
Development

No branches or pull requests

2 participants