Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input border theming is broken #7353

Open
akosyakov opened this issue Mar 17, 2020 · 7 comments
Open

input border theming is broken #7353

akosyakov opened this issue Mar 17, 2020 · 7 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help theming issues related to theming

Comments

@akosyakov
Copy link
Member

One can reproduce with HC theme, but also with any theme which redefines input.border.

In VS Code:
Screenshot 2020-03-16 at 16 01 04

In Theia:
Screenshot 2020-03-16 at 16 01 09
@akosyakov akosyakov added bug bugs found in the application theming issues related to theming scm issues related to the source control manager help wanted issues meant to be picked up, require help labels Mar 17, 2020
@kittaakos kittaakos changed the title scm input border theming is broken input border theming is broken Mar 17, 2020
@kittaakos kittaakos removed the scm issues related to the source control manager label Mar 17, 2020
@kittaakos
Copy link
Contributor

Same for SIW:

screencast 2020-03-17 13-24-56

@kittaakos
Copy link
Contributor

Also, no borders around the dialog buttons:
Screen Shot 2020-03-17 at 13 32 02

@kittaakos
Copy link
Contributor

This issue is the same as #6743, isn't it?

@akosyakov
Copy link
Member Author

This issue is the same as #6743, isn't it?

It is not about HC. HC is only a way to reproduce. You can create a custom theme with another input.border color and it won't work.

#6743 about checking that HC works properly

@kittaakos
Copy link
Contributor

I cannot see what files are selected in the explorer either.

screencast 2020-03-17 13-40-52

@akosyakov
Copy link
Member Author

I cannot see what files are selected in the explorer either.

This one I think already about HC support :) Maybe file a new issue just to be sure that does not get lost while fixing this issue.

@kittaakos kittaakos mentioned this issue Mar 17, 2020
Closed
@kittaakos
Copy link
Contributor

I am going to look into this and #6743.

@kittaakos kittaakos self-assigned this Apr 2, 2020
@kittaakos kittaakos removed their assignment Jul 18, 2021
@colin-grant-work colin-grant-work mentioned this issue Sep 15, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help theming issues related to theming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittaakos @akosyakov