[terminal] Pressing HOME no longer goes to beginning of line, but scrolls up

[jankeromnes]

Description

There was an XtermJS upgrade recently, and I think that it broke the HOME shortcut in Theia's Terminal.

Here is a screencast showing the new problem: https://youtu.be/_auOJvi17Rs

Reproduction Steps

1. Start typing some command into Theia's terminal
2. Press your HOME key (or corresponding key-stroke, e.g. fn + LeftArrow on a Macbook)

Expected: Cursor jumps to beginning of typed command

Actual: Terminal scrolls all the way to the top(!)

OS and Theia version: latest Theia (in Gitpod on Mac OS)

Diagnostics:

[akosyakov]

It's a regression after #7121

[AndrienkoAleksandr]

I will take a look.

[AndrienkoAleksandr]

We should use `shift+Home' shortcut.

[akosyakov]

Resolved by #7305

[jankeromnes]

Thanks again for fixing this @AndrienkoAleksandr!

I confirm that it now works well, but I also noticed a few weird behaviors FYI:

• Home works as expected 🎉 ❤️
• End too
• Shift+Home scrolls to top of Terminal, so works as expected too
• Shift+End just adds the letter F for some reason (keybinding not actually implemented in Theia, so this is probably Mac OS weirdness, and End already scrolls to bottom of Terminal)
• PageUp / PageDown don't work in Terminals, except in paginated output (less / git log) where it works well. I think this behavior was pre-existing, and is fine by me.
• Shift+PageUp / Shift+PageDown forcefully jumps one page up or down, even if you're looking at paginated content (i.e. the less "window" will scroll out of view). I guess that's ok.

[jankeromnes]

I also added two minor questions in #7305 (comment), please take a look when you have time.

[akosyakov]

@jankeromnes it would be better to put weird behaviour in a new issue, closed issues are not actionable.