Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theming] input area not visible on light themes when in the main area #6781

Closed
vince-fugnitto opened this issue Dec 20, 2019 · 2 comments
Closed
Assignees
Labels
keybindings issues related to keybindings theming issues related to theming vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

Description

The --theia-input-background color used for input areas is not visible on light themes when widgets are present in the main area. The color works well for the sidebars but is hardly visible otherwise.

For example (the keyboard shortcuts widget):
Notice the input area with the add search term.

Main Area

Screen Shot 2019-12-20 at 11 57 40 AM

Sidebar (Activity Bar)

Screen Shot 2019-12-20 at 11 57 49 AM

Steps to Reproduce

  1. prerequisite: VS Code like theming (colors and icons) #6475
  2. start the application
  3. navigate to the keyboard shortcuts widget
  4. switch to a light theme
  5. notice the input is hardly visible (dock the widget to the side)
@vince-fugnitto vince-fugnitto added the theming issues related to theming label Dec 20, 2019
@akosyakov
Copy link
Member

Background seems to be fine, it is the same in VS Code:
Screen Shot 2019-12-20 at 20 10 30

But input borders are missing. We should check which colors are used in VS Code for the keybinidng widget and apply them as well.

@akosyakov akosyakov added keybindings issues related to keybindings vscode issues related to VSCode compatibility labels Dec 20, 2019
@akosyakov
Copy link
Member

@akosyakov akosyakov self-assigned this Dec 26, 2019
akosyakov added a commit that referenced this issue Dec 26, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
…themes

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings theming issues related to theming vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants