Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An extension application developer has to explicitly depend on @theia/monaco #544

Open
kittaakos opened this issue Sep 22, 2017 · 3 comments
Labels
extension system issues related to the extension system monaco issues related to monaco

Comments

@kittaakos
Copy link
Contributor

Otherwise, the generated webpack configuration breaks as the monaco dependencies are not in the node_modules folder.

Ideally, an extension should be able to contribute to the webpack generation phase, and the monaco part should not be hardcoded.

@kittaakos
Copy link
Contributor Author

Another problem is that I have to explicitly depend on workspace, otherwise, the application does not start:

index.js:35 Error: A command with id 'file:open' does not exist.
    at ActionMenuNode.get [as label] (file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:15630:23)
    at ActionMenuNode.get [as sortString] (file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:15646:45)
    at file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:15575:19
    at Array.sort (native)
    at CompositeMenuNode.addNode (file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:15574:24)
    at MenuModelRegistry.findSubMenu (file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:15539:17)
    at MenuModelRegistry.registerSubmenu (file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:15497:30)
    at NavigatorMenuContribution.registerMenus (file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:27044:18)
    at MenuModelRegistry.onStart (file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:15478:25)
    at FrontendApplication.startContributions (file:///Users/akos.kitta/Desktop/theia-electron-app/lib/bundle.js:14803:20)
module.exports.Promise.resolve.then.then.then.then.then.then.catch.reason @ index.js:35

@kittaakos
Copy link
Contributor Author

@akosyakov, I think you have updated the extension manager to handle the transitive dependencies correctly. If so, could you please confirm and close this? Thank you!

@kittaakos kittaakos added the extension system issues related to the extension system label Nov 27, 2017
@akosyakov
Copy link
Member

Yes, it is backed-in the webpack config generator. Ideally, each extension could contribute to the generation process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension system issues related to the extension system monaco issues related to monaco
Projects
None yet
Development

No branches or pull requests

3 participants