support octicon in the quick pick items

[akosyakov]

See #4005 (comment)

I cannot come up with a way to reuse Monaco quick palette for it. It could be we need to implement our own to have the control over it.

It's reproducible with checkout status bar item contributed by vscode git extension.

[kittaakos]

New icons were added to Octicon in VS Code: https://code.visualstudio.com/updates/v1_35#_updated-octicons

[benoitf]

FYI now it's called codicons https://github.com/microsoft/vscode-codicons :-)
microsoft/vscode#82729

[RomanNikitenko]

I investigated the issue and found that the octiconLabel.mock is used for rendering icons instead of the real implementation.
If I understand correctly the cause of the problem is the redirection
At the same time the last version of vs code doesn't have such redirection

@akosyakov maybe you know more about this problem, could you confirm or refute my assumptions about it.

I would like to know your opinion about the direction of resolving this problem.
Is it possible to avoid the redirection and use the vs code implementation for rendering instead of the mock?
Or should we consider the providing the own implementation of rendering on theia side?

Thanks in advance!

[akosyakov]

Maybe we "just" should upgrade to latest Monaco and it will come with octicons already? Could you check in the monaco playground?

[RomanNikitenko]

I checked for 0.19.2 version of Monaco, codicons work well for command palette: https://youtu.be/Y1PRBSYKtLM

[akosyakov]

We have to migrate then. It is a bit involving, see https://github.com/eclipse-theia/theia/wiki/LSP-and-Monaco-integration#migration-guidelines and last migration PR: #5901.

The plan was to land #6852, switch to VS Code extensions instead of Theia extensions for typescript/node (cc @vince-fugnitto @marcdumais-work ) and automate tests from #5901

[azatsarynnyy]

... see https://github.com/eclipse-theia/theia/wiki/LSP-and-Monaco-integration#migration-guidelines and last migration PR: #5901

@akosyakov PR: #5901 - am I understand it right that all amount of work in this PR is related to upgrading to a newer version of monaco?

The plan was to land #6852, switch to VS Code extensions instead of Theia extensions for typescript/node (cc @vince-fugnitto @marcdumais-work ) and automate tests from #5901

@akosyakov do you mean that upgrading monaco work shouldn't be started before completing the mentioned plan?

[akosyakov]

@akosyakov PR: #5901 - am I understand it right that all amount of work in this PR is related to upgrading to a newer version of monaco?

It is more. First https://github.com/TypeFox/monaco-languageclient have to be migrated, after that we should update and test Theia. Testing usually is the biggest effort. If you want to start working on monaco-languageclient, I can make you maintainers that you can move faster, see TypeFox/monaco-languageclient#164

@akosyakov do you mean that upgrading monaco work shouldn't be started before completing the mentioned plan?

Upgrading monaco-languageclient is irrelevant to it. Generally I would like to minimize testing effort, but if it is super important we can do manual testing one time more.