Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement][tree] All tree widgets automatically select either the root or its first child if any #4570

Open
kittaakos opened this issue Mar 14, 2019 · 0 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves tree issues related to the tree (ex: tree widget)

Comments

@kittaakos
Copy link
Contributor

Here is the related code: https://github.com/theia-ide/theia/blob/67bc2d4e9ebb0dd169005f80fdeb41074f61463a/packages/core/src/browser/tree/tree-widget.tsx#L247-L257

Subclasses cannot customize it conveniently. (At least I am not aware of it, if you know, let me know)

Extract the logic to a protected method, so that subclasses can adjust the behavior.

🎖 Bonus: introduce an optional property on the TreeProps for it.

(Why is it called as a TreeProps and not TreeWidgetProps? Confusing.)

@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves tree issues related to the tree (ex: tree widget) labels Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

No branches or pull requests

1 participant