Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty Preference editor pop-ups two dialogs when closing the editor #2780

Closed
lmcbout opened this issue Sep 5, 2018 · 3 comments
Closed

Dirty Preference editor pop-ups two dialogs when closing the editor #2780

lmcbout opened this issue Sep 5, 2018 · 3 comments
Labels
preferences issues related to preferences

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Sep 5, 2018

After opening the preferences setting and do a modification (No auto-save), if you try to kill the preferences editor, it will pop-up two dialogs to save the new information. Only one pop-up dialog should be enough when pressing "Don't save" button.

prefdialogsavedtwice

@elaihau
Copy link
Contributor

elaihau commented Nov 27, 2018

It happens because both PreferenceContainer and PreferenceEditor are Saveable, and therefore the dialog gets created once on each.

@lmcbout
Copy link
Contributor Author

lmcbout commented Nov 27, 2018

@elaihau Even if there is two Preferences (editor_container),
we should either save both or cancel both on the first dialog

@vince-fugnitto
Copy link
Member

Closing as the bug is no longer reproducible with the new user-interface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences
Projects
None yet
Development

No branches or pull requests

3 participants