Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Close Editor" in the File menu did not get the correct translation value #13333

Closed
noneghost opened this issue Jan 31, 2024 · 0 comments · Fixed by #13412
Closed

"Close Editor" in the File menu did not get the correct translation value #13333

noneghost opened this issue Jan 31, 2024 · 0 comments · Fixed by #13412
Labels
bug bugs found in the application localization issues related to localization/internalization/nls
Milestone

Comments

@noneghost
Copy link
Contributor

Bug Description:

"Close Editor" in the File menu did not get the correct translation value after use mater branch.

企业微信截图_17066684863542

Steps to Reproduce:

After #13331

registry.registerMenuAction(CommonMenus.FILE_CLOSE, {
commandId: CommonCommands.CLOSE_MAIN_TAB.id,
label: nls.localizeByDefault('Close Editor'),
order: '1'
});

  1. Get "Close Editor" value when use "Close Editor" key, Get right value when use "close Editor" key.
  2. It may be due to a mismatch in the DefaultKey values obtained by nls.

get(defaultValue: string): string | undefined {
const normalized = Localization.normalize(defaultValue);
return this.data.get(normalized) || this.data.get(normalized.toUpperCase());
}

企业微信截图_17066686467715
企业微信截图_17066686828364

Additional Information

  • Theia Version: master branch (commit id: b15b639)
@msujew msujew added bug bugs found in the application localization issues related to localization/internalization/nls labels Feb 22, 2024
@jfaltermeier jfaltermeier added this to the 1.48.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants