Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot DragAndDrop Files into TreeView #12404

Closed
tsmaeder opened this issue Apr 12, 2023 · 1 comment · Fixed by #12409 · 4 remaining pull requests
Closed

Cannot DragAndDrop Files into TreeView #12404

tsmaeder opened this issue Apr 12, 2023 · 1 comment · Fixed by #12409 · 4 remaining pull requests
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Bug Description:

Dragging files into a tree view contributed from a VS Code Extensions seems broken at the moment, even if the tree view correctly asks for the files mime type.

Steps to Reproduce:

  1. Contribute a tree view with the files mime type set in it's TreeDragAndDropController.dropTypes array.
  2. Drag and drop a file from the Windows explorer onto an item in the tree
  3. Observe: the handleDrop() method of the d&d controller is not invoked.

Additional Information

  • Operating System: Window 11
  • Theia Version: Electron/master
@tsmaeder tsmaeder added bug bugs found in the application vscode issues related to VSCode compatibility labels Apr 12, 2023
@tsmaeder
Copy link
Contributor Author

This is weird, since the original PR included a "how to test" scenario that covers dragging from the OS.

tsmaeder added a commit to tsmaeder/theia that referenced this issue Apr 13, 2023
@tsmaeder
Fix check for presence of files in DnD. Fixes eclipse-theia#12404
6d40686 
Also clears "local transfers" when drag ends, preventing the items from
a previous D&D operation to spill over to the next one.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder mentioned this issue Apr 13, 2023
Merged
1 task
tsmaeder added a commit to tsmaeder/theia that referenced this issue Apr 13, 2023
@tsmaeder
Fix check for presence of files in DnD. Fixes eclipse-theia#12404
d2a73c0 
Also clears "local transfers" when drag ends, preventing the items from
a previous D&D operation to spill over to the next one.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tortmayr added a commit that referenced this issue Apr 27, 2023
@tsmaeder @tortmayr
Fix check for presence of files in DnD. Fixes #12404 (#12409)
a84ea35 
Also clears "local transfers" when drag ends, preventing the items from
a previous D&D operation to spill over to the next one.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Co-authored-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
jonah-iden pushed a commit to jonah-iden/theia that referenced this issue May 2, 2023
@tsmaeder @tortmayr @jonah-iden
Fix check for presence of files in DnD. Fixes eclipse-theia#12404 (ec…
1dabb6f 
…lipse-theia#12409)

Also clears "local transfers" when drag ends, preventing the items from
a previous D&D operation to spill over to the next one.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Co-authored-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
This was referenced Nov 27, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 28, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 21, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
1 participant
@tsmaeder