Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only make use of necessary builtins #11964

Open
vince-fugnitto opened this issue Dec 6, 2022 · 2 comments
Open

ci: only make use of necessary builtins #11964

vince-fugnitto opened this issue Dec 6, 2022 · 2 comments
Labels
builtins Issues related to VS Code builtin extensions ci issues related to CI / tests proposal feature proposals (potential future features)

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

The project currently downloads/resolves the list of builtins during CI (for Linux) and tests against them during our API integration tests. The proposal is to not download and resolve the entire list of plugins (most notably the extension-pack) but instead only fetch the subset which are needed for the tests to pass.

The change would ultimately reduce build times, and put less unnecessary load on open-vsx.

A WIP which shows the tests pass with the subset can be viewed here (not the actual final implementation).

Any thoughts? @msujew @JonasHelming

@vince-fugnitto vince-fugnitto added ci issues related to CI / tests proposal feature proposals (potential future features) builtins Issues related to VS Code builtin extensions labels Dec 6, 2022
@JonasHelming
Copy link
Contributor

I do not see any drawbacks in the proposed solution, do I miss anything?

@msujew
Copy link
Member

msujew commented Dec 8, 2022

Sounds reasonable to me as well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions ci issues related to CI / tests proposal feature proposals (potential future features)
Projects
None yet
Development

No branches or pull requests

3 participants