Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate config for context Menu styles #10376

Open
dev-artem-o opened this issue Nov 3, 2021 · 1 comment
Open

Create separate config for context Menu styles #10376

dev-artem-o opened this issue Nov 3, 2021 · 1 comment
Labels
electron issues related to the electron target proposal feature proposals (potential future features)

Comments

@dev-artem-o
Copy link

Feature Description:

The latest release added the ability to select custom or native titleBarStyle for non-osx systems. If you select custom titleBarStyle, then both the titleBar and the context menu will be custom. Is it possible to split this option so that you can select a custom context menu and leave the native titlebar and vice verca?

Maybe you need to add a separate preference config window.contextMenuStyle with native and custom values?

@msujew msujew added the electron issues related to the electron target label Nov 3, 2021
@vince-fugnitto
Copy link
Member

@dev-artem-o the current behavior of window.titleBarStyle follows the implementation and behavior of it's vscode counterpart which I believe the framework should support by default, and not attempt to split it.

vscode:

'window.titleBarStyle': {
	'type': 'string',
	'enum': ['native', 'custom'],
	'default': isLinux ? 'native' : 'custom',
	'scope': ConfigurationScope.APPLICATION,
	'description': localize('titleBarStyle', "Adjust the appearance of the window title bar. On Linux and Windows, this setting also affects the application and context menu appearances. Changes require a full restart to apply.")
},

Instead, the re-implementation of the preference and/or a new preference window.contextMenuStyle can probably be implemented by your own application to suit your use-case.

@vince-fugnitto vince-fugnitto added the proposal feature proposals (potential future features) label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target proposal feature proposals (potential future features)
Projects
None yet
Development

No branches or pull requests

3 participants