Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eclipse-theia/theia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dd8ef797956eac400291b3a8144d65fb8fa76c43
Choose a base ref
...
head repository: eclipse-theia/theia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8d78ae6bad8247147df13dd7752d60da5848c8c6
Choose a head ref
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Oct 10, 2019

  1. Revise git watchers 

    - trying to guarantee watcher do not leak
  - `sync` called in `GitRepositoryManager.run` in not-watching state must not leave it watching when done
  - watcher created per repository should not depend on something bound in connection scope
- `Git` should be bound as singleton
  - connection scoped git access should be a proxy for the singleton git
- `git status` calls for same repository should not supersede each other
- `sync` requests should not pile up when a watcher is busy

ref #4436

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
    @AlexTugarev
    AlexTugarev committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    20648a2 View commit details
    Browse the repository at this point in the history

  2. !!!REMOVE ME!!! debug logging for git watchers 

    Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
    @AlexTugarev
    AlexTugarev committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    8d78ae6 View commit details
    Browse the repository at this point in the history
Loading