From bf607eadcf272cfed4192191f2a63115f5a8a480 Mon Sep 17 00:00:00 2001 From: Vladimir Piskarev Date: Mon, 18 Mar 2024 19:27:32 +0300 Subject: [PATCH] Add a comment that commands for dirty diff navigation need to be always available --- packages/scm/src/browser/scm-contribution.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/scm/src/browser/scm-contribution.ts b/packages/scm/src/browser/scm-contribution.ts index 98a46ece26452..f896363f313de 100644 --- a/packages/scm/src/browser/scm-contribution.ts +++ b/packages/scm/src/browser/scm-contribution.ts @@ -193,6 +193,10 @@ export class ScmContribution extends AbstractViewContribution impleme execute: () => this.acceptInput(), isEnabled: () => !!this.scmFocus.get() && !!this.acceptInputCommand() }); + + // Note that commands for dirty diff navigation need to be always available. + // This is consistent with behavior in VS Code, and also with other similar commands (such as `Next Problem/Previous Problem`) in Theia. + // See https://github.com/eclipse-theia/theia/pull/13104#discussion_r1497316614 for a detailed discussion. commandRegistry.registerCommand(SCM_COMMANDS.GOTO_NEXT_CHANGE, { execute: () => this.dirtyDiffNavigator.gotoNextChange() });