Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a Session is missing a viewpoint, refresh does nothing but no user feedback is provided #457

Open
flatombe opened this issue Sep 13, 2024 · 0 comments

Comments

@flatombe
Copy link
Contributor

When refreshing a representation through the UI, org.eclipse.sirius.business.api.dialect.command.RefreshRepresentationsCommand is created and executed.

To determine whether the refresh may actually happen, org.eclipse.sirius.business.api.dialect.AbstractRepresentationDialectServices.areRequiredViewpointsSelected(DRepresentation) is called.

When some of the required viewpoints are missing from the session, the refresh does not happen, but there is no feedback to the user that the refresh did not really occur.

Ideally, the refresh action should probably be disabled when it cannot operate, and the UI should explain to the user why that is the case.
At the very least, an error/warning should be logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant