Skip to content

Commit 8bedfd8

Browse files
vogellalaeubi
authored andcommitted
Removes log methods from Terminal activator
Using ILog.of is the more modern approach
1 parent a9793d3 commit 8bedfd8

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/UIPlugin.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616
import java.util.ArrayList;
1717
import java.util.List;
1818

19-
import org.eclipse.core.runtime.IStatus;
2019
import org.eclipse.core.runtime.Platform;
21-
import org.eclipse.core.runtime.Status;
2220
import org.eclipse.jface.resource.ImageDescriptor;
2321
import org.eclipse.jface.resource.ImageRegistry;
2422
import org.eclipse.swt.custom.CTabFolder;
@@ -271,14 +269,6 @@ public static ImageDescriptor getImageDescriptor(String key) {
271269
return getDefault().getImageRegistry().getDescriptor(key);
272270
}
273271

274-
public static void log(String msg, Throwable e) {
275-
log(new Status(IStatus.ERROR, getUniqueIdentifier(), IStatus.ERROR, msg, e));
276-
}
277-
278-
public static void log(IStatus status) {
279-
getDefault().getLog().log(status);
280-
}
281-
282272
public static boolean isOptionEnabled(String strOption) {
283273
String strEnabled = Platform.getDebugOption(strOption);
284274
if (strEnabled == null) {

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/tabs/OpenFileMouseHandler.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.eclipse.core.resources.ResourcesPlugin;
2626
import org.eclipse.core.runtime.Adapters;
2727
import org.eclipse.core.runtime.CoreException;
28+
import org.eclipse.core.runtime.ILog;
2829
import org.eclipse.core.runtime.Path;
2930
import org.eclipse.core.runtime.Platform;
3031
import org.eclipse.jface.text.BadLocationException;
@@ -197,7 +198,7 @@ public void mouseUp(ITerminalTextDataReadOnly terminalText, int line, int column
197198
}
198199
}
199200
} catch (IllegalArgumentException | NullPointerException | ExecutionException | PartInitException e) {
200-
UIPlugin.log("Failed to activate OpenResourceDialog", e); //$NON-NLS-1$
201+
ILog.of(getClass()).error("Failed to activate OpenResourceDialog", e); //$NON-NLS-1$
201202
}
202203

203204
}

0 commit comments

Comments
 (0)