Registering MouseEnter and MouseMove Events in PopupCloser #2996
amartya4256
started this conversation in
General
Replies: 1 comment 2 replies
-
@fedejeanne @HeikoKlare What do you think? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
We have an issue with Edge Browser here: eclipse-platform/eclipse.platform.swt#2072
The reason:
SWT cannot recieve the MouseUp or MouseDown event from the tooltip as the tooltip is running a webview instance (Edge browser) inside and when you click on the javadoc, the click is registered by Webview and not SWT. This is a problem since, there's no known way to directly get this mouseclick event out of Webview to SWT unlike IE. Hence, how we did it in eclipse-platform/eclipse.platform.swt#1551, we rather need to rely on mouseEnter and mouseMove instead.
The problem is that the toolTip is created using AdditionalInformationController where PopupCloser is resposible from replacing the tooltip control with the one with a scrollbar, but it doesn't handle any MouseEnter and MouseMove event unlike AbstarctHoverControlManager:Closer which is responsible for replacing the tooltip control in case of eclipse-platform/eclipse.platform.swt#1551.
Hence, we need it to also register listeners for MouseEnter and MouseMove as done in the PR #2977. Although, this addition of extra events doesn't have any visual effects on other widgets (as far as I have tested), but it can indeed trigger replaceInformationControl on there 2 extra events too for all the consumers using a popupCloser.
We can rather accept this solution as a feature to the widgets reacting to "mouseHover" for replacing the information control or figure out how edge can send a mouseUp event (which doesn't seem to be quite straight forward or maybe even not possible)
Refer PR:
#2977
Beta Was this translation helpful? Give feedback.
All reactions