Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate writing of relocation record header #4803

Open
12 of 13 tasks
dsouzai opened this issue Feb 20, 2019 · 0 comments
Open
12 of 13 tasks

Consolidate writing of relocation record header #4803

dsouzai opened this issue Feb 20, 2019 · 0 comments

Comments

@dsouzai
Copy link
Contributor

dsouzai commented Feb 20, 2019

This is the general plan as discussed with @mstoodle and @jdmpapin :

  1. Move the platform specific (but mostly common) code out from the various J9AheadOfTimeCompile.cpp files and into the common J9AheadOfTimeCompile.cpp.
  2. Use TR_RelocationRecord (or more specifically, the appropriate sub types) to write the relocation data into the buffer that gets written out to the SCC.
  3. Remove the (again per platform but common) tables of sizes of Relocation Record Binary Templates. Given that the virtual function bytesInHeaderAndPayload returns exactly the data in the tables, perhaps there's a way of having only canonical method of getting this information.
  4. Move the various Relocation Record Binary Template definitions back into RelocationRecord.cpp.

The plan is to do this one relocation record at a time in order to both simplify the code review process as well as testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant