Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify asynccheckEvaluator on Z #12472

Open
fjeremic opened this issue Apr 19, 2021 · 0 comments
Open

Simplify asynccheckEvaluator on Z #12472

fjeremic opened this issue Apr 19, 2021 · 0 comments

Comments

@fjeremic
Copy link
Contributor

@joransiu suggested a small code improvement in #742 (comment) to the asynccheckEvaluator which can simplify one of the paths:

https://github.com/eclipse/openj9/blob/94649e13230cf293f73f060f83b331eb38174d8b/runtime/compiler/z/codegen/J9TreeEvaluator.cpp#L2189-L2211

As per the review comment, the code in lowerAsyncCheck will have ensured the memref we compare against will not have a base and an index register. If in case this does happen for whatever reason, the code in generateSILInstruction has us taken care of because it will separate the index register:

https://github.com/eclipse/omr/blob/840473a5de22834948bed9a8acc5bfb36a6ad10b/compiler/z/codegen/S390GenerateInstructions.cpp#L1565-L1568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant