Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old CPU detection code on Z #10575

Open
harryyu1994 opened this issue Sep 11, 2020 · 1 comment
Open

Remove old CPU detection code on Z #10575

harryyu1994 opened this issue Sep 11, 2020 · 1 comment

Comments

@harryyu1994
Copy link
Contributor

A few month ago I added a new version of CPU detection for all platforms in OMR. As a way to make sure the new version does not give us any unexpected behaviour, we have kept the old version in the codebase and used the old version as a reference to test against the new version. It's been a few months and we have not seen any issues with the new version so I think it's safe to remove the old version now. Note that as things stand right now only Z and Power's old version can be removed. x86's old version cannot be removed currently because standalone OMR still relies on it. And the reason Z and Power's old version can be removed is because there were no CPU detection support in standalone OMR on these platforms in the first place.

Another reason I would really like the old version gone is because there is nothing preventing developers from still using the old version queries as well as adding new code to the old version.

Additionally, with Portable AOT support being added to Z, in order to avoid any unexpected behaviour I need to make sure to eliminate all instances where we are still using the old version of CPU detection.

@harryyu1994
Copy link
Contributor Author

@fjeremic @mpirvu FYI

@fjeremic fjeremic changed the title Remove Old CPU detection code on Z Remove old CPU detection code on Z Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants