Add eaEscapeHelperSymbol #4665
Merged
Add eaEscapeHelperSymbol #4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenJ9 Escape Analysis optimization currently overloads the meaning of the OSR helper callees as part of its analysis. This change introduces a new non-helper symbol for this optimization pass to use to avoid overloaded meanings and the resultant confustion in the codebase. Signed-off-by: Andrew Craik <ajcraik@ca.ibm.com>
andrewcraik
requested review from
0xdaryl,
Leonardo2718,
mstoodle and
vijaysun-omr
as code owners
| { | ||
| if (!element(eaEscapeHelperSymbol)) | ||
| { | ||
| TR::MethodSymbol* sym = TR::MethodSymbol::create(trHeapMemory(), TR_None); |
There was a problem hiding this comment.
Is the rationale for TR_None here that it is not a helper in the sense that it is'nt expected to reach the codegen even ?
|
@genie-omr build all |
vijaysun-omr
approved these changes
Dec 12, 2019
|
Looks safe to me since this is infrastructure for adding the new symbol. Tests have also passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenJ9 Escape Analysis optimization currently overloads the meaning of the OSR
helper callees as part of its analysis. This change introduces a new non-helper
symbol for this optimization pass to use to avoid overloaded meanings and the
resultant confusion in the codebase.
This helper is added to OMR because its aliasing etc must match that of the various other
helpers used for the same purpose and any other language implementing an escape
analysis-like optimization would benefit from the presence of this non-helper.
Signed-off-by: Andrew Craik ajcraik@ca.ibm.com