Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: metal C files not handled properly in omrport #5449

Open
dnakamura opened this issue Aug 5, 2020 · 0 comments
Open

CMake: metal C files not handled properly in omrport #5449

dnakamura opened this issue Aug 5, 2020 · 0 comments

Comments

@dnakamura
Copy link
Contributor

dnakamura commented Aug 5, 2020

The way we have z/OS metal c files implemented uses add_custom_command to generate a .o file from the .mc. However, CMake does not allow adding object files to object_libraries

CMake Error at /home/jenkins/devinn/openj9-openjdk-jdk11-zos/omr/cmake/modules/OmrTargetSupport.cmake:70 (add_library):
  OBJECT library "omrport_obj" contains:

    omrlpdat.o

  but may contain only sources that compile, header files, and other files
  that would not affect linking of a normal library.

Why this doesnt trigger an error when building omr, I have no idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants