Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine whether analyzers should decrement children node counts or not #4916

Open
fjeremic opened this issue Mar 9, 2020 · 1 comment
Open

Comments

@fjeremic
Copy link
Contributor

fjeremic commented Mar 9, 2020

Currently, as we found out in #4914 the TR_S390BinaryAnalyser and TR_S390BinaryCommutativeAnalyser work in different ways w.r.t. decrementing node counts. The former seems to decrement always, while the latter does not. We need to standardize on which way we should lean.

Since the analyzer ends up evaluating the children my preference would be for the analyzer to be responsible for decrementing the children as well.

@fjeremic fjeremic changed the title Determine whether analyzers should decrememnt children node counts or now Determine whether analyzers should decrememnt children node counts or not Mar 9, 2020
@0xdaryl 0xdaryl changed the title Determine whether analyzers should decrememnt children node counts or not Determine whether analyzers should decrement children node counts or not Mar 10, 2020
@0xdaryl
Copy link
Contributor

0xdaryl commented Mar 10, 2020

The convention that nodes are decremented where they are evaluated is historically how the backends were architected to work (although the rules have been bent in a number of places and not necessarily for the good). I agree the analyzers should decrement the ref counts on the children it evaluates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants