Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing presenceService.isClientAwake(destination) check #1643

Closed
mattemyoo opened this issue Aug 21, 2024 · 3 comments
Closed

Removing presenceService.isClientAwake(destination) check #1643

mattemyoo opened this issue Aug 21, 2024 · 3 comments
Labels
question Any question about leshan

Comments

@mattemyoo
Copy link

Question

Hello. Is there any risk of messing anything up if we were to disable for example these lines?:

// If the client is sleeping, warn the user and return
if (!presenceService.isClientAwake(destination)) {
throw new ClientSleepingException("The destination client is sleeping, request cannot be sent.");
}

The reason is that we would like to still try to send a request to our device even though it is considered asleep.

@mattemyoo mattemyoo added the question Any question about leshan label Aug 21, 2024
@sbernard31
Copy link
Contributor

Is there any risk of messing anything up if we were to disable for example these lines?

I think it should be OK 🤔

The reason is that we would like to still try to send a request to our device even though it is considered asleep.

Are you using the PresenceService or you don't use it at all ?

@sbernard31
Copy link
Contributor

(let me know when we can close this issue)

@mattemyoo
Copy link
Author

Yes we are using PresenceService. It seems like 93s without a response, we the sleep event is triggered, right?

Anyway, you can close this issue now. We discovered the max timeout flag and did some more digging into the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Any question about leshan
Projects
None yet
Development

No branches or pull requests

2 participants