Migrate examples to test suite

[mvcbot]

Issue by gtudan
Saturday Sep 29, 2018 at 15:39 GMT
Originally opened as mvc-spec/ozark#209

---

It would be great to have am integration testsuite that runs locally, so that we can make sure we don't break anything. Currently the tests are more examples than tests as building, deploying and testing them is quiet difficult.

See here for the discussion on the mailing list: https://groups.google.com/d/msg/jsr371-users/NZXgRX9610E/jb1l706fCQAJ

[mvcbot]

Comment by chkal
Sunday Sep 30, 2018 at 07:09 GMT

---

A big +1 for this! ;-)

One thing I would like to mention. As you may know we are currently in the process of migrating Ozark to the Eclipse Foundation (see the Eclipse Krazo proposal). As part of this migration, we have to check the licenses of our dependencies to make sure that all the license are allowed (see #179). It MAY be possible, that we need to drop some extensions because they have dependencies with disallowed license. But that's not official yet. But I guess if we start to migrate the examples to the new test suite module, we should prefer to migrate example apps which test core features and example apps which test ASL2-licensed extensions first. Just to make sure we don't spend too much time on migrating apps which we have to remove as part of the migration anyway.

[gtudan]

We've moved quiet a few examples to the test suite by now, focusing on stuff that were extensions or implementational details of Krazo and hence were not covered by the TCK.

I think most of what is left is already covered by tests from the TCK. So I would like to ask the other developers what we should do with them. Should we:

1. still port them to the test suite? Maybe as starting point for more in-depth tests?
2. leave them as-is to have some examples that could serve as starting points for the users?
3. Remove them, since they served their purpose as early test-suite and are superseded by the TCK?

[chkal]

@gtudan Thanks for bringing this up!

I don't think we should go with (1) as most of the tests are part of the TCK now. However, I think it might be possible that they contain some tests which actually test more than the TCK does at the moment. So IMO it would be too early for (3). Maybe we should go with (2) for now? Maybe we can remove them at a later point?