Enable @ConstrainedTo on Features #4055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Supol <jan.supol@oracle.com>
jansupol
force-pushed
the
constrinedtoonfeatures
branch
from
a9c6925 to
c7b3881
Compare
| enabledFeatureClasses.add(registration.getFeatureClass()); | ||
| enabledFeatures.add(feature); | ||
| final RuntimeType runtimeTypeConstraint = registration.getFeatureRuntimeType(); | ||
| if (runtimeTypeConstraint == null || type.equals(runtimeTypeConstraint)) { |
Contributor
There was a problem hiding this comment.
This check should be performed before line 674, so we do not create an injected instance of a Feature that should not exist in this type of runtime.
tomas-langer
requested changes
Feb 18, 2019
Contributor
tomas-langer
left a comment
tomas-langer
left a comment
There was a problem hiding this comment.
Check for runtime type should be performed sooner - see comment in file.
Signed-off-by: Jan Supol <jan.supol@oracle.com>
Signed-off-by: Jan Supol <jan.supol@oracle.com>
senivam
approved these changes
Feb 18, 2019
This was referenced Jun 26, 2021
This was referenced Aug 5, 2021
This was referenced Sep 5, 2021
This was referenced Oct 4, 2021
This was referenced Oct 18, 2021
This was referenced Oct 21, 2021
Merged
Merged
This was referenced Oct 21, 2021
Closed
Closed
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jan Supol jan.supol@oracle.com