Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a proper way for error responses to CleanupPersistence commands #476

Open
Yannic92 opened this issue Aug 26, 2019 · 0 comments
Open

Comments

@Yannic92
Copy link
Contributor

Yannic92 commented Aug 26, 2019

PR #475 revealed that there were two usages of the ID of CleanupPersistenceResponses as message to provide error messages. I think it would be better to provide an actual error response that holds a cause for example.

See: https://github.com/eclipse/ditto/blob/cdd8bb1bdfe65eeb4aa59eb2e7db4ba5454e80a1/services/concierge/actors/src/main/java/org/eclipse/ditto/services/concierge/actors/cleanup/EventSnapshotCleanupCoordinator.java#L367 and https://github.com/eclipse/ditto/blob/cdd8bb1bdfe65eeb4aa59eb2e7db4ba5454e80a1/services/concierge/actors/src/main/java/org/eclipse/ditto/services/concierge/actors/cleanup/EventSnapshotCleanupCoordinator.java#L395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant